main, win: create test runner in windows #3
Conversation
mini-test.gyp
Outdated
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "targets": [ { | |||
| "target_name": "mini-test", | |||
| "type": "<!(gypkg type)", | |||
| "type": "static_library", | |||
There was a problem hiding this comment.
I'd rather keep it. Any point in dropping it?
There was a problem hiding this comment.
I wanted to run "real" GYP to get Visual Studio project files 😞
src/spawn-win.c
Outdated
| static char executable_path[BUFSIZE]; | ||
|
|
||
| int popen_complete(const char* cmd) | ||
| { |
There was a problem hiding this comment.
Style, please put { on the same line as popen_complete.
Let's make popen_complete static.
include/mini/common.h
Outdated
| @@ -6,11 +6,20 @@ | |||
| #include <string.h> | |||
| #include <errno.h> | |||
|
|
|||
| #define BUFSIZE 4096 | |||
There was a problem hiding this comment.
I'd rather move BUFSIZE to some private file. This file is a public API.
There was a problem hiding this comment.
So to src/spawn-win.c
| #include <Windows.h> | ||
| #define ABORT ExitProcess(42) | ||
| #else | ||
| #define ABORT abort() |
There was a problem hiding this comment.
There is no abort on Windows? How do they live?
There was a problem hiding this comment.
We have but it makes allot of noise (Tries to find a debugger and creates a useless coredump)
src/spawn-win.c
Outdated
| PROCESS_INFORMATION ProcessInformation; | ||
| ZeroMemory(&ProcessInformation, sizeof(ProcessInformation)); | ||
|
|
||
| // BOOL WINAPI CreateProcess( |
There was a problem hiding this comment.
I know it sounds lame, but let's use /* */ comments here for consistency.
|
|
||
| // Wait until child process exits. | ||
| DWORD wait_ret = WaitForSingleObject(ProcessInformation.hProcess, INFINITE); | ||
| CHECK_EQ(wait_ret, WAIT_OBJECT_0, "Process ended strange"); |
There was a problem hiding this comment.
Does it happen on non-zero exit code?
There was a problem hiding this comment.
No, only on strage cases
| Return code/value | Description |
|---|---|
| WAIT_ABANDONED 0x00000080L | The specified object is a mutex object that was not released by the thread that owned the mutex object before the owning thread terminated. Ownership of the mutex object is granted to the calling thread and the mutex state is set to nonsignaled. If the mutex was protecting persistent state information, you should check it for consistency. |
| WAIT_OBJECT_0 0x00000000L | The state of the specified object is signaled. |
| WAIT_TIMEOUT 0x00000102L | The time-out interval elapsed, and the object's state is nonsignaled. |
| WAIT_FAILED 0xFFFFFFFF | The function has failed. To get extended error information, call GetLastError. |
|
PTAL |
src/spawn-win.c
Outdated
| PROCESS_INFORMATION ProcessInformation; | ||
| ZeroMemory(&ProcessInformation, sizeof(ProcessInformation)); | ||
|
|
||
| /* |
There was a problem hiding this comment.
I'm sorry for nit-picking again. But could it be indented?
|
|
||
| // Wait until child process exits. | ||
| DWORD wait_ret = WaitForSingleObject(ProcessInformation.hProcess, INFINITE); | ||
| CHECK_EQ(wait_ret, WAIT_OBJECT_0, "Process ended strange"); |
|
Landed with fixes in cb2b17e . Thank you! Would you care to check that my fixes didn't break anything on Windows? |
|
Works. Looked at the diff, you just bunched the declarations... seems semantically equal. |
|
Thanks! |
For this case, I could do it simpler than libuv (since the runner prints it's own errors)
Fixes: #1